Re: [libvirt] [jenkins-ci PATCH 2/5] guests: Update mappings for sheepdog
On Tue, Jul 09, 2019 at 09:51:29AM +0200, Andrea Bolognani wrote:
On Mon, 2019-07-08 at 17:14 +0100, Daniel P. Berrangé wrote:
> On Mon, Jul 08, 2019 at 06:05:36PM +0200, Andrea Bolognani wrote:
> > Debian has removed sheepdog from the distribution, and at this
> > point Debian 9 is now the only supported release that still
> > includes it.
>
> s/only supported release/only supported Debian release/
I thought the fact that I was exclusively talking about Debian made
that obvious, but sure, I can make it obvious-er :)
It can be read both ways :-)
> because Fedora still ships it
And so does Ubuntu... So at this point it actually might make more
sense to express the mapping as
sheepdog:
default:
Fedora: sheepdog
Ubuntu: sheepdog
Debian9: sheepdog
to highlight the fact that shipping it is the exception rather than
the rule; accordingly, it also ends up being shorter O:-)
> It does look kind of zombie upstream though. No commits since 1 in Jun
> 2018, and before that nothing until mid 2017.
That's probably at least part of the reason why people have stopped
shipping it...
Anyway with a tweaked commit message
Reviewed-by: Daniel P. Berrangé <berrange(a)redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|