Re: [libvirt] PATCH: Pass -name argument to QEMU
On Thu, May 15, 2008 at 10:24:35PM +0100, Daniel P. Berrange wrote:
Xenner doesn't start its help output right at the start of line,
Ah. :/
and there isn't any other output there that causes ambiguity in
current qemu help output:
# qemu-kvm | grep -- -drive
-drive [file=file][,if=type][,bus=n][,unit=m][,media=d][index=i]
If one happens to be added in the future, that's fine because -drive
will be enabled anyway for future releases.
I wasn't only worried about future releases, but also previous ones. I
didn't want to have to check back through qemu's vcs for instances of
"-drive", so I coded defensively instead. :) What versions of QEmu does
libvirt actually claim to support? If we only support recent versions,
then we're probably fine.
--
Soren Hansen |
Virtualisation specialist | Ubuntu Server Team
Canonical Ltd. | http://www.ubuntu.com/
Attachments:
- signature.asc (application/pgp-signature — 189 bytes)