On Mon, Feb 03, 2014 at 12:23:46PM -0700, Eric Blake wrote:
On 02/03/2014 11:30 AM, Daniel P. Berrange wrote:
> The project has historically operated as a meritocratic
> consensus based community. Formally document what has
> always been an unwritten assumption amongst the community
> participants. Also include an explicit code of conduct
> to prempt any potential, but unlikely, future problems.
> + <li>User help: join the IRC channel or mailing list to assist or
advice
> + other users in troubleshooting the problems they face.</li>
Here would be an ideal place to add <a href...> pointing to the contact
page, so someone can actually find the IRC channel or list :)
Good idea.
> + <li>Code review: look at patches which are submitted and critique
> + the code to identify bugs, potential design problems or other
> + issues which should be addressed before the code is accepted</li>
Maybe even mention that merely testing a build with the proposed patch
applied, without actually understanding the code, is also a valid form
of review.
I've added another bullet point about testing patches + release candidates.
Daniel
--
|:
http://berrange.com -o-
http://www.flickr.com/photos/dberrange/ :|
|:
http://libvirt.org -o-
http://virt-manager.org :|
|:
http://autobuild.org -o-
http://search.cpan.org/~danberr/ :|
|:
http://entangle-photo.org -o-
http://live.gnome.org/gtk-vnc :|