On Wed, Aug 05, 2020 at 01:16:01PM +0200, Andrea Bolognani wrote:
On Wed, 2020-08-05 at 12:51 +0200, Pavel Hrdina wrote:
Commit <74416b1d4849ef77ef31de5344dd75f03094434b> added check for rl_completion_quote_character to make sure we have correct readline library. Commit <a9443bc9a9ef451b46306e66ed3b706756fc1414> added inaccurate comment that it's a function.
So it was my fault after all O:-)
+ correct_rl = cc.has_header_symbol('readline/readline.h', 'rl_completion_quote_character', prefix: '#include <stdio.h>') + if not correct_rl + if get_option('readline').enabled() + error('readline is missing rl_completion_quote_character')
This matches the original error message, but thinking about it again I would suggest changing it to something like
error('readline >= @0@ was not found'.format(readline_version))
because the specifics of the symbol are not important here, we just happen to be using it as a witness.
Most of the error messages could use some rewording and I feel that it should be done separately.
Either way,
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Thanks, I'll leave the error message cleanup for different day. Pavel