Re: [libvirt] [PATCH 0/1] enospace disk error policy
On Fri, Apr 09, 2010 at 11:44:30AM +0300, Dan Kenigsberg wrote:
On Thu, Apr 08, 2010 at 04:11:32PM -0400, David Allan wrote:
> Dan Kenigsberg requested that we add an option to explicitly request enospace as the
disk error policy.
>
Well, to be more exact, I asked if leaving it out was intentional ;-)
(But I do think that alowing explicity here is a good idea, thanks)
I do have one issue with error_policy: for qemu-0.12 (with -drive and
id=) libvirt creates a command line such as
qemu-kvm -drive file=/tmp/1.qcow2,format=qcow2,if=none,werror=stop,id=drive-ide0-0-0
Which qemu does not like ("werror is no supported by this format"). This
error goes away if the "if=none" clause is dropped. I'm not sure if it
is not a qemu bug, though.
Yeah its a QEMU bug - there's a BZ open about this. Basically they have
a bogus checking on IF_NONE that doesn't take account of the new style
options using -device
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|