Re: [libvirt PATCH 9/9] tests: Add tests for unknown elements and attributes in cpu defintion
On Tue, 2020-09-29 at 11:22 +0200, Peter Krempa wrote:
On Mon, Sep 21, 2020 at 15:07:32 +0200, Tim Wiederhake wrote:
> Signed-off-by: Tim Wiederhake <twiederh(a)redhat.com>
> ---
[...]
> diff --git a/tests/cputestdata/x86_64-bogus-element.xml
> b/tests/cputestdata/x86_64-bogus-element.xml
> new file mode 100644
> index 0000000000..79f98bad18
> --- /dev/null
> +++ b/tests/cputestdata/x86_64-bogus-element.xml
> @@ -0,0 +1,3 @@
> +<cpu>
> + <nonExistantElement/>
> +</cpu>
I'm not persuaded that there's value in such test.
This was my approach to adding negative tests to the "virsh
[hypervisor-]cpu-compare --validate" feature to make sure that schema
violations are actually caught. If this is not the correct place to do
so, I would be grateful for a pointer in the right direction.
Tim