Re: [libvirt] [PATCH v2 0/6] Add support for setting the emulator scheduler parameters

On Mon, Apr 15, 2019 at 03:14:21PM +0200, Martin Kletzander wrote: >I/O threads and vCPU threads already support setting schedulers, but until now >it was impossible to do so for the main QEMU thread (emulator thread in the >libvirt naming). This is, however, requested for some very specific scenarios, >for example when vCPU threads are running at such priority that could starve the >main thread. > I don't like the XML format,

but it's consistent with the existing scheds.

>v2: > - news.xml addition in a separate patch > >Martin Kletzander (6): > conf: Parse common scheduler attributes in separate function > conf: Format thread IDs optionally > docs: Mention iothreadsched element in the docs and reword > conf: Add support for emulatorsched > qemu: Add support for emulatorsched > docs: Add emulatorsched support to news.xml > > docs/formatdomain.html.in | 25 +++-- > docs/news.xml | 12 +++ > docs/schemas/domaincommon.rng | 5 + > src/conf/domain_conf.c | 136 +++++++++++++++++------- > src/conf/domain_conf.h | 1 + > src/qemu/qemu_process.c | 2 +- > tests/genericxml2xmlindata/cputune.xml | 37 +++++++ > tests/genericxml2xmloutdata/cputune.xml | 40 +++++++ > tests/genericxml2xmltest.c | 2 + > 9 files changed, 212 insertions(+), 48 deletions(-) > create mode 100644 tests/genericxml2xmlindata/cputune.xml > create mode 100644 tests/genericxml2xmloutdata/cputune.xml > With at least the commit message in 2/6 fixed: Reviewed-by: Ján Tomko <jtomko(a)redhat.com&gt;

Jano