Re: [Libvir] PATCH: 7/16: virsh core commands

> +static int > +cmdPoolDelete(vshControl * ctl, vshCmd * cmd) > +{ > + virStoragePoolPtr pool; > + int ret = TRUE; > + char *name; > + > + if (!vshConnectionUsability(ctl, ctl->conn, TRUE)) > + return FALSE; > + > + if (!(pool = vshCommandOptPool(ctl, cmd, "pool", &name))) > + return FALSE; > + > + if (virStoragePoolDelete(pool, 0) == 0) { > + vshPrint(ctl, _("Pool %s deleteed\n"), name); > + } else { > + vshError(ctl, FALSE, _("Failed to delete pool %s"), name); > + ret = FALSE; > + virStoragePoolFree(pool); > + } > + > + return ret; > +} just wondering, assuming the Delete operation really destroys on-disk storage and potentially a large set, shouldn't we add some kind of interactive confirmation ? Contrary to destroying a domain where state is preserved on the disk and rather easy to recover and destroying a network which has very little state, maybe here we need to do something special, optionally adding a -f flag to bypass confirmation like in rm.