Re: [libvirt PATCH] ci: Makefile: Add distcheck target

On Wed, 2020-06-17 at 16:05 +0200, Erik Skultety wrote: > On Wed, Jun 17, 2020 at 03:18:48PM +0200, Andrea Bolognani wrote: > > On Wed, 2020-06-17 at 12:00 +0200, Erik Skultety wrote: > > > +ci-distcheck@%: > > > + $(MAKE) -C $(CI_ROOTDIR) ci-build@$* CI_MAKE_ARGS="distcheck" > > > > I'm not sure we want to have such a proxy for all possible make > > targets, especially since CI_MAKE_ARGS exists and is specifically > > intended for the purpose of running > > > > $ make ci-build@centos-8 CI_MAKE_ARGS="syntax-check distcheck" > > I think that ship has sailed the moment we added ci-check. > What I'll do is respin this patch with extending the ci-help output as well as > adding CI_MAKE_ARGS to the help output, because like you said, one has to skim > through the Makefile to see what's available to them. No ships have sailed, we can still make all the changes we deem necessary as well as avoid those we consider undesirable: ci-check existing does not mean that we have blanket permission for adding ci-cov, ci-pdf, ci-mostlyclean and everything else. Anyway, if you think ci-distcheck is worth having I will not stand in the way - as long as you document it properly :)