On 06/24/2011 10:38 AM, Eric Blake wrote:
On 06/24/2011 01:34 AM, Michal Privoznik wrote:
5) I see you've put the data structures and parsing/formatting functions that are used by both network_conf.c and domain_conf.c in the util directory. I've been wondering myself what to do with similar structs/functions that will be used in both network and domain XML (eg, <virtualport> will soon be used by both) - does everyone agree this is the right way to handle it? Or should there be a common file in the conf directory instead? (I don't have an opinion, but want to "do the right thing" when I write my own code) Yeah, I was thinking the same way. When I wrote the code, I've decided for src/util. But I would not hesitate if somebody wants it in src/conf. We already have src/util/sysinfo.[ch] for common parsing/formatting of sysinfo XML, so I'm okay with src/util.
Ah, good. I hadn't seen that one. So it's all settled.