Re: [libvirt] [PATCH] conf: forbid negative values in virDomainParseScaledValue

On 10/29/2014 10:35 AM, Martin Kletzander wrote: > It makes sense for none of the callers to have negative value as an > output and, fortunately, if anyone tried defining domain with negative > memory or any other value parsed by virDomainParseScaledValue(), the > resulting value was 0. That means we can error out during parsing as > it won't break anything. > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1155843 > > Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com&gt; > --- > "it won't break anything" -- famous last words? > > src/conf/domain_conf.c | 25 ++++++++++++++++--------- > 1 file changed, 16 insertions(+), 9 deletions(-) ACK. Sounds like a bug fix, and therefore safe for 1.2.10