
23 Nov
2021
23 Nov
'21
12:50 p.m.
Thank you for reviewing the patch. 2021年11月23日(火) 21:37 Michal Prívozník <mprivozn@redhat.com>:
[...]
The word variable is also used only inside a while loop (not visible in the context). So it can be declared local there instead of here. I'll fix that before pushing.
OK.
However, we do require developers to provide signoff for their patches to signal their compliance with DCO:
https://libvirt.org/hacking.html#developer-certificate-of-origin
No need to resend the whole patch, it's sufficient if you reply with your SoB line.
OK. Are just the following lines sufficient? -- [PATCH 1/1] bash-completion: fix variable leaks of "IFS" and "word" Signed-off-by: Koichi Murase <myoga.murase@gmail.com> -- Thank you, Koichi