On 08/09/2017 11:07 AM, Daniel P. Berrange wrote:
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- libvirt-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Did you get a compiler that complained?
diff --git a/libvirt-utils.c b/libvirt-utils.c index 727397d..0af13dc 100644 --- a/libvirt-utils.c +++ b/libvirt-utils.c @@ -108,7 +108,7 @@ virReallocN(void *ptrptr, return -1; } tmp = realloc(*(void**)ptrptr, size * count); - if (!tmp && (size * count)) { + if (!tmp && ((size * count) != 0)) {
Do you need the extra (), or will one of these shorter forms also work? if (!tmp && size * count != 0) if (!tmp && (size * count) != 0) -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org