On 24/3/26 04:19, Pierrick Bouvier wrote:
On 3/23/26 8:21 AM, Philippe Mathieu-Daudé wrote:
SchemaInfoEnumMember::values field has been deprecated for more than 5 years (see commit 75ecee72625 "qapi: Enable enum member introspection to show more than name"), it should be safe enough to remove.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- docs/about/deprecated.rst | 6 ------ docs/about/removed-features.rst | 7 +++++++ qapi/introspect.json | 12 +----------- scripts/qapi/introspect.py | 3 +-- 4 files changed, 9 insertions(+), 19 deletions(-)
By curiosity, is this patch goal is simply to remove a deprecated feature/code, or does it unlock something beyond it? No judgment here, that's a genuine question, and both are valid reasons!
In a previous thread Daniel said past deprecation period, feature must be removed, otherwise undeprecated and re-introduced. I'm just trying to be consistent with the deprecation process, removing what doesn't seem worth to re-introduce (for the code I'm able to figure out at least). Maybe we should clarify the deprecation process, clarifying that, and mentioning that maintainers sending pull request to commit patches with deprecations are also a commitment to remove code when the proper released is out.
Looks good to me, to the limit of my qapi knowledge :). Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Thanks!