Re: [libvirt] PATCH: Ensure configure.ac is fully quoted

"Daniel P. Berrange" <berrange(a)redhat.com&gt; wrote: > As suggested by Jim, this patch goes through the configure script and makes > sure all args to macros are fully quoted. NB, this applies on top of the > NUMA/cpu pinning patches I sent the other day, not CVS. ... Looks fine. Thanks for doing that! I confirmed that your change induces no change in configure. > - AC_PATH_PROG(MOUNT, [mount], [], [$PATH:/sbin:/usr/sbin]) > - AC_PATH_PROG(UMOUNT, [umount], [], [$PATH:/sbin:/usr/sbin]) > + AC_PATH_PROG([MOUNT], [mount], [], [$PATH:/sbin:/usr/sbin]) > + AC_PATH_PROG([UMOUNT], [umount], [], [$PATH:/sbin:/usr/sbin]) > if test "$with_storage_fs" = "yes" ; then > if test -z "$MOUNT" ; then AC_MSG_ERROR(We need mount for FS storage driver) ; fi > if test -z "$UMOUNT" ; then AC_MSG_ERROR(We need mount for FS storage driver) ; fi BTW, I noticed a typo in context: that latter message should say "umount". Also, in your numactl patch, you can remove the " for security" bit: + AC_DEFINE_UNQUOTED([HAVE_NUMACTL], 1, [whether Numactl is available for security]) Re autoconf quoting, you can quote a few AC_MSG_ERROR arguments like the two above. Here's a patch that does a few more, including each AC_HELP_STRING use. You're welcome to apply it on top of yours.