Re: [libvirt] [PATCH v2 1/5] Public virDomainMigrateSetMaxDowntime API

On Thu, Mar 18, 2010 at 08:12:44PM +0100, Jiri Denemark wrote: > --- > include/libvirt/libvirt.h.in | 4 +++ > src/libvirt.c | 49 ++++++++++++++++++++++++++++++++++++++++++ > src/libvirt_public.syms | 5 ++++ > 3 files changed, 58 insertions(+), 0 deletions(-) > > diff --git a/include/libvirt/libvirt.h.in b/include/libvirt/libvirt.h.in > index 0d1b5b5..d983e5f 100644 > --- a/include/libvirt/libvirt.h.in > +++ b/include/libvirt/libvirt.h.in > @@ -408,6 +408,10 @@ int virDomainMigrateToURI (virDomainPtr domain, const char *duri, > unsigned long flags, const char *dname, > unsigned long bandwidth); > > +int virDomainMigrateSetMaxDowntime (virDomainPtr domain, > + unsigned long long downtime, > + unsigned int flags); > + > /** > * VIR_NODEINFO_MAXCPUS: > * @nodeinfo: virNodeInfo instance > diff --git a/src/libvirt.c b/src/libvirt.c > index 1d9b878..07837a3 100644 > --- a/src/libvirt.c > +++ b/src/libvirt.c > @@ -11265,3 +11265,52 @@ error: > virDispatchError(conn); > return -1; > } > + > + > +/** > + * virDomainMigrateSetMaxDowntime: > + * @domain: a domain object > + * @downtime: maximum tolerable downtime for live migration, in nanoseconds > + * @flags: fine-tuning flags, currently unused, use 0 We discussed that previously, obviously the nanosecond accuracy is not expected but most uses of durations in the API now use nanoseconds and after all it's better to have something too fine grained than too coarse there