Re: [libvirt] [jenkins-ci PATCH 3/5] guests: Make PERL5LIB dynamic

On Tue, 2018-06-05 at 11:42 +0100, Daniel P. Berrangé wrote: > On Mon, May 21, 2018 at 06:53:25PM +0200, Andrea Bolognani wrote: > > Instead of having to specify this separately for every > > guest due to minor differences in the environment, figure > > it out at login time by asking Perl itself for the > > information we need. > > We still have the problem that any time a package update is done it > might pull in a newer Perl, which will change the path, but our > Jenkins slave never picks it up until the VM is rebooted. Is that the case, though? I'm not entirely clear on the lifecycle, but it might very well be the case that the Jenkins agent spawns a separate session for each job, in which case changes to the shell profile would be picked up immediately.

> I wonder if we can solve this by instead of putting all these > env vars in the main bash profile, we create a > > 'jenkins-ci.sh' > > that contains all the env variables. We can then source that > from the bash profile, and also source it as the first thing > we do in every build job too. If we really need to do that, might as well source ~/.bashrc right at the start of every build job instead of having a separate script: the only unnecessary bits are setting up the prompt and bash completion, but there's no harm in having them in there.