On 10/11/19 5:12 AM, Peter Krempa wrote:
On Thu, Oct 10, 2019 at 14:08:12 -0400, John Snow wrote:
On 10/10/19 7:54 AM, Peter Krempa wrote:
On Thu, Oct 10, 2019 at 13:42:26 +0200, Philippe Mathieu-Daudé wrote:
On 10/10/19 1:26 PM, Peter Krempa wrote:
[...]
To be honest, I didn't really review the code nor the documentation. I actually reviewed only the idea itself in the context of integration with libvirt and that's why I didn't go for 'Reviewed-by:'.
The gist of the citation above is that we should stick to well known tags with their well known meanings and I think that considering this a 'review' would be a stretch of the definiton.
I wasn't aware that PMM wanted to avoid non-standard tags; I consider them to be for human use, but I can change that behavior.
Peter, I'll change it to an ACK (as suggested by Kevin) is that's OK by you.
Sure! I'll spell it out even for compliance:
ACKed-by: Peter Krempa <pkrempa@redhat.com>
Thanks, applied to my IDE tree: https://github.com/jnsnow/qemu/commits/ide https://github.com/jnsnow/qemu.git --js