Re: [libvirt] [PATCH 4/7] Turn virLogSource into a struct instead of an enum

On 03/03/2014 12:18 PM, Daniel P. Berrange wrote: Thanks for separating the meat from the global switchover. So we're basically tossing out the enum of where an error came from, in favor of a more complex struct that could theoretically once again include the source information in a later patch. What's the XXX for, something that gets fixed later? Prior to patch 2/7, virLogVMessage behaved differently for VIR_LOG_FROM_ERROR than for anything else. 2/7 hoisted a condition here to virRaiseErrorFull, but changed the distinguishing factor to whether virErrorLogPriorityFilter is set. Now this patch gets rid of the distinction altogether (since virLogSelf is global), although it could theoretically be reinstated once you have per-file sources. Exactly what was that code used for again, and why are we safe using it? I'd feel a bit more comfortable acking 2/7 and this patch if you can explain a bit more in the commit message why we are dropping the distinction based on error source. Ah - this means that the journal will log per-file information (after the next patch converts global virLogSelf into per-file), instead of just the 5 broad categories that virLogSource used to provide. So I think this is a fair trade, but still wonder if the commit message can make it clearer. Jan pointed out the compilation error here. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org