Re: [libvirt] [Qemu-devel] [PATCH v2 3/3] raw-posix: Re-open host CD-ROM after media change
On (Tue) 05 Apr 2011 [09:40:05], Stefan Hajnoczi wrote:
> See http://www.spinics.net/lists/linux-scsi/msg51504.html
I don't think that patch updates the block inode size. We'd need to
call fs/block_dev.c:revalidate_disk() instead of directly calling
cdi->disk->fops->revalidate_disk(cdi->disk).
fs/block_dev.c:revalidate_disk() calls check_disk_size_change(), which
will update the inode size.
Then the patch is buggy :-) As Tejun also says in the thread, the
patch should be in the block layer, not sr.c.
(btw that patch does update /sys/block/sr0/size, so that part of
revalidation is done.)
Amit