Re: [libvirt] [PATCH 3/7] Test driver implementation of virStorageVolCreateXMLFrom

On Mon, May 04, 2009 at 01:42:58PM -0400, Cole Robinson wrote: > Signed-off-by: Cole Robinson <crobinso(a)redhat.com&gt; > --- > src/test.c | 95 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 95 insertions(+), 0 deletions(-) > > + > + if (VIR_ALLOC_N(privvol->target.path, > + strlen(privpool->def->target.path) + > + 1 + strlen(privvol->name) + 1) < 0) { > + virReportOOMError(pool->conn); > + goto cleanup; > + } > + > + strcpy(privvol->target.path, privpool->def->target.path); > + strcat(privvol->target.path, "/"); > + strcat(privvol->target.path, privvol->name); > + privvol->key = strdup(privvol->target.path); > + if (privvol->key == NULL) { > + virReportOOMError(pool->conn); > + goto cleanup; > + } Be a little shorter to just call virAsprintf() for target.path ACK aside from that Daniel