Re: [PATCH v2 0/3] libvirt-guests.sh: Declare and assign separately to avoid masking return values

19 Jan 2026


      On a Monday in 2026, Michal Privoznik via Devel wrote:
...
v2 of:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/RXHDI...
diff to v1:
- perfected the syntax-check rule
- due to this fewer changes to libvirt-guests.sh.in file are necessary
Michal Prívozník (3):
 libvirt-guests.sh: Declare and assign separately to avoid masking
   return values
 libvirt-guest.sh.in: Fix logical error in guest_is_on()
 syntax-check: Introduce sc_prohibit_local_with_subshell rule
build-aux/syntax-check.mk  | 11 +++++++++++
tools/libvirt-guests.sh.in | 12 ++++++++----
2 files changed, 19 insertions(+), 4 deletions(-)
Reviewed-by: Ján Tomko <jtomko@redhat.com>

Jano