Re: [PATCH 07/13] Allow NUMA nodes without vCPUs
On 6/24/20 10:49 AM, Michal Privoznik wrote:
QEMU allows creating NUMA nodes that have memory only.
These are somehow important for HMAT.
With check done in qemuValidateDomainDef() for QEMU 2.7 or newer,
You're mentioning "QEMU 2.7 or newer" but the code in qemu_validate is
checking for QEMU_CAPS_NUMA. I'm assuming that QEMU 2.7 is where
QEMU_CAPS_NUMA first appeared. In this case, I think that an adendum
like
"QEMU 2.7 or newer (checked via QEMU_CAPS_NUMA)"
would be nice to clarify.
we can be sure that the vCPUs are fully assigned to NUMA nodes in
domain XML.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
docs/formatdomain.html.in | 2 +
docs/schemas/cputypes.rng | 8 ++-
src/conf/numa_conf.c | 59 ++++++++++---------
src/libxl/xen_xl.c | 10 ++--
src/qemu/qemu_command.c | 26 ++++----
src/qemu/qemu_validate.c | 22 +++----
tests/qemuxml2argvdata/numatune-no-vcpu.args | 33 +++++++++++
tests/qemuxml2argvdata/numatune-no-vcpu.xml | 42 +++++++++++++
tests/qemuxml2argvtest.c | 1 +
tests/qemuxml2xmloutdata/numatune-no-vcpu.xml | 1 +
tests/qemuxml2xmltest.c | 1 +
11 files changed, 149 insertions(+), 56 deletions(-)
create mode 100644 tests/qemuxml2argvdata/numatune-no-vcpu.args
create mode 100644 tests/qemuxml2argvdata/numatune-no-vcpu.xml
create mode 120000 tests/qemuxml2xmloutdata/numatune-no-vcpu.xml
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index bd662727d3..07dcca57f5 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -1840,6 +1840,8 @@
consistent across qemu and libvirt versions.
<code>memory</code> specifies the node memory
in kibibytes (i.e. blocks of 1024 bytes).
+ <span class="since">Since 6.6.0</span> the
<code>cpus</code> attribute
s/Since 6.6.0/Since 6.5.0 ?
Reviewed-by: Daniel Henrique Barboza <danielhb413(a)gmail.com>