Re: [libvirt] [PATCH] lxc: fix mknod file type

Hi, On Thu, May 7, 2009 at 7:39 AM, Ryota Ozaki <ozaki.ryota(a)gmail.com&gt; wrote: > Hi Daniel, > > On Wed, May 6, 2009 at 7:31 PM, Daniel P. Berrange <berrange(a)redhat.com&gt; wrote: >> On Wed, May 06, 2009 at 04:01:32AM +0900, Ryota Ozaki wrote: >>> Hi, >>> >>> This patch fixes the 2nd argument of mknod syscall. The argument >>> should include a file type, i.e., S_IFCHR in this case, otherwise >>> created files will be regular files. >> >> Wierd. I guess no one has anything that uses this  becasue current >> code is clearly useless / broken. > > I think so unfortunately ;< Actually lxc does not work in my system > with cgroups enabled. lxc code probably remains some other bugs. oops, I've found a bug in the previous patch. Please replace with the following patch.