Re: [libvirt] PATCH: 25/25: Support ac97 sound card
"Daniel P. Berrange" <berrange(a)redhat.com> wrote:
On Tue, Jan 13, 2009 at 05:49:02PM +0000, Daniel P. Berrange wrote:
> QEMU now has support for a sound card of type "ac97", so enable
> that in the XML parser / qemu driver.
>
> Also remove some unused cruft relating to sound in Xen.
>
> domain_conf.c | 3 ++-
> domain_conf.h | 1 +
> xend_internal.c | 46 ----------------------------------------------
> 3 files changed, 3 insertions(+), 47 deletions(-)
Now we added 'ac97', we can no longer blindly convert Xen's
'all' string into all possible sound card types - must restrict
it to just the 3 that were around historically. This fixes the
Xen test case
Thanks. That looks fine and fixed it for me.
I've pushed that incremental to the git branch,
along with the two suggested syntax-check fixes.