Re: [libvirt] [PATCH 20/24] maint: improve VIR_ERR_INVALID_STREAM usage

On 12/28/2013 11:11 AM, Eric Blake wrote: > For streams validation, we weren't consistent on whether to > use VIR_FROM_NONE or VIR_FROM_STREAMS. Furthermore, in > many API, we want to ensure that a stream is tied to the > same connection as the other object we are operating on; > while other API failed to validate the stream at all. > Similar to previous patches, use a common macro to make it > nicer. > > * src/datatypes.h (virCheckStreamReturn, virCheckStreamGoto): > New macros. > (VIR_IS_STREAM, VIR_IS_CONNECTED_STREAM): Drop unused macros. > * src/libvirt.c: Use macro throughout. > (virLibStreamError): Drop unused macro. > > Signed-off-by: Eric Blake <eblake(a)redhat.com&gt; > --- > src/datatypes.h | 29 +++++++++++-- > src/libvirt.c | 128 ++++++++++++++++++++++---------------------------------- > 2 files changed, 76 insertions(+), 81 deletions(-) > ACK virDomainOpenConsole certainly assumed things previously!