22 Sep
2010
22 Sep
'10
12:28 p.m.
On 09/21/2010 12:58 PM, Daniel P. Berrange wrote:
On Fri, Sep 17, 2010 at 02:21:56PM -0400, Stefan Berger wrote:
Either one of the following patches fixes a bug appearing on big endian machines where the returned XML is not the one that is expected (see test/nwfilterxml2xmltest). The problem is due to for example the casting of a pointers to unsigned integers to void * and then back to 16 bit integers.
I have prepared 2 different solutions for the problem. I think the one with the union is the better one, which I am posting before the shorted solution. Both solutions make the nwfilterxml2xmltest pass on a ppc64 machine. I'd pick the one with the union too, so ACK to that one.
Daniel Pushed.
Stefan