On Mon, 22 Oct 2007 12:39:50 -0400 Daniel Veillard wrote:
The following patch finishes the cleanup for NUMA parsing code: - the cpuset parsing is moved to xml.c - some comments and cleanups of the include then add the output of a (cpus '...') line based on the /domain/vcpu/@cpuset attributes, this is parsed and reserialized as ranges to avoid any possibility of misinterpretation of say ^ or any special syntax we may want to add in the future. A few things to note: - dependant on the tiny patch I sent earlier today - if we notice that the set covers all CPU maybe we should avoid outputing (cpus '...'), trivial to add - mostly untested yet
It seems work fine for creating a guest, i.e. I can set the cpuset by "virsh create" with XML file containing a cpuset parameter. This fix will solve "create" of the following BZ. - BZ#223833: FEAT RHEL5.2: About the setting of CPU affinity at virsh create/reboot https://bugzilla.redhat.com/show_bug.cgi?id=223833 I think we also need to fix for "start/define/dumpxml". So, I attached the patch for them. Could you check it ? Anyway, I will have some more test for the cpuset. thanks, Saori Fukuta