
21 Sep
2018
21 Sep
'18
10:47 a.m.
On Thu, Sep 20, 2018 at 05:34:38PM -0400, John Ferlan wrote:
Coverity noted that each of the fmemopen called used the strlen value in order to allocate space, but that neglected space for terminating null string. So just add 1 to the strlen.
Signed-off-by: John Ferlan <jferlan@redhat.com> --- Reviewed-by: Erik Skultety <eskultet@redhat.com>
Although, I'm wondering whether it's worth having an internal wrapper like the STREQ stuff we have to mitigate the off-by-1 errors in cases like these, but I guess there would be cases, where that might be undesirable.