Re: [PATCH 05/14] vsh: Introduce '--completers-missing' for 'self-test' command
On 9/17/21 9:36 AM, Peter Krempa wrote:
On Fri, Sep 17, 2021 at 09:31:13 +0200, Michal Prívozník wrote:
> On 9/16/21 7:10 PM, Peter Krempa wrote:
>> Make it simple to spot which options of which commands are missing
>> autocompletion functions by introducing this hidden option.
>>
>> In the future when we'll have completers for everything this can be also
>> used as a hard fail so that completers are always added.
>>
>> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
>> ---
>> tools/vsh.c | 28 ++++++++++++++++++++++++----
>> tools/vsh.h | 3 ++-
>> 2 files changed, 26 insertions(+), 5 deletions(-)
>>
I'll perhaps do another round later.
I've already ACKed the whole series. It's okay to do it as a follow up
patch. In fact I've came across couple of places that could use our
attention and I'll send patches as soon as you merge yours.
Michal