On 07/10/2017 02:07 PM, Peter Krempa wrote:
Few cleanups I made to cleanup the def->JSON generator for qemu
disk sources.
Peter Krempa (10):
qemu: command: Set port number only for TCP transport
util: Extract helper to retrieve default port for network protocol
util: storage: Fill in default ports for gluster and iscsi
conf: Pre-fill default ports when parsing network disk sources
qemu: command: Remove default port numbers for NBD and GLUSTER
qemu: command: Call qemuGetDriveSourceProps only if necessary
qemu: Move qemuGetDriveSourceProps to qemu_block
qemu: block: Refactor and rename qemuGetDriveSourceProps
qemu: block: refactor and rename qemuBuildGlusterDriveJSONHosts
qemu: block: rename and refactor qemuBuildGlusterDriveJSON
po/POTFILES.in | 1 +
src/conf/domain_conf.c | 3 +
src/libvirt_private.syms | 1 +
src/qemu/qemu_block.c | 156 ++++++++++++++
src/qemu/qemu_block.h | 3 +
src/qemu/qemu_command.c | 229 ++++-----------------
src/util/virstoragefile.c | 65 ++++++
src/util/virstoragefile.h | 4 +
.../generic-disk-network-http.xml | 4 +-
.../qemuxml2xmlout-disk-drive-network-gluster.xml | 2 +-
10 files changed, 273 insertions(+), 195 deletions(-)
ACK series.
Although, for future work it might be interesting to look at possibility
of storing port as an int instead of string?
Michal