Re: [PATCH v3 10/10] hmp: Deprecate 'singlestep' member of StatusInfo

On Tue, 25 Apr 2023 at 13:10, Markus Armbruster <armbru(a)redhat.com&gt; wrote: > > Peter Maydell <peter.maydell(a)linaro.org&gt; writes: > > > -# Notes: @singlestep is enabled through the GDB stub > > +# Notes: @singlestep is enabled on the command line with > > +# '-accel tcg,one-insn-per-tb=on', or with the HMP > > +# 'one-insn-per-tb' command. > > You're deleting "enabled through the GDB stub". Is this one of the > misstatements you alluded to in the commit message Yes -- this field has never been anything to do with GDB-enabled singlestep (or for that matter with emulation of any guest-CPU architecture singlestep functionality). I assume that whoever originally wrote that text was confused by the terrible name of the command line option/global variable.