Re: [libvirt] [PATCH] virExec: fix logic bug

On 12/24/2010 08:42 AM, Eric Blake wrote: > As pointed out in https://bugzilla.redhat.com/show_bug.cgi?id=659855#c9, > commit c3568ec2 introduced a regression where we no longer close any > fd's beyond FD_SETSIZE. > > * src/util/util.c (__virExec): Continue to close fd's beyond > keepfd range. > Reported by Stefan Praszalowicz. Ping - this is a regression bug fix; anyone willing to review it in time for inclusion in 0.8.7? > +++ b/src/util/util.c > @@ -570,7 +570,7 @@ __virExec(const char *const*argv, >              i != null && >              i != childout && >              i != childerr && > -            (!keepfd || (i < FD_SETSIZE && !FD_ISSET(i, keepfd)))) { > +            (!keepfd || i >= FD_SETSIZE || !FD_ISSET(i, keepfd))) { >              tmpfd = i; >              VIR_FORCE_CLOSE(tmpfd); >          }