Re: [libvirt] [PATCHv3 1/5] domifaddr: Implement the public API

On 08/22/2013 04:18 PM, nehaljwani wrote: [meta-review; I'm saving the technical review for later] Your previous submission https://www.redhat.com/archives/libvir-list/2013-August/msg01206.html began with this line in the body (well, munged by the archives, but you get the drift): From: Nehal J Wani <nehaljw kkd1 gmail com> But this submission does not. If I use 'git am' directly on your mail, then 'git shortlog' would show two different groupings for patches from you unless we also patch .mailmap to cover the difference in naming. Furthermore, _this_ email claims to be from 'nehaljwani', while your reply in this series, https://www.redhat.com/archives/libvir-list/2013-August/msg01221.html, claims to be from 'Nehal J. Wani'. That's now three spellings for mail purporting to be the same address. While inconsistency in the use of 'J' vs. 'J.' in your initial is not the end of the world, we definitely prefer legal names rather than pseudonyms (such as your login name) in git authorship information. Therefore, you ought to figure out how to configure 'git send-email' to match the preferred spelling of your non-git mails. After all, git only adds a From: line to the top of a patch when the authorship is different from the mail sender configuration, and while a From: line in the body of an email generally means that someone else wrote the patch (fine), seeing a From: line for your own submission is generally a sign of a mis-configuration (embarrassing). If you have a reason to resend this series, you should rebase it and use 'git commit --amend --author=....' on each patch to adjust the authorship information. No need to resend just yet: wait for the technical review. If I find nothing wrong in the technical review that warrants a resend for other reasons, then I don't mind touching up authorship this time around, since it is still one of your first contributions. But the bar gets higher the more you contribute :) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org