Re: [libvirt PATCH 1/2] gitlab-ci.yaml: Introduce a variable to disable long broken jobs
On Mon, Jan 11, 2021 at 01:53:49PM +0000, Daniel P. Berrangé wrote:
On Mon, Jan 11, 2021 at 02:42:54PM +0100, Erik Skultety wrote:
> Unfortunately GitLab doesn't have a different mechanism on how to mark
> jobs as skipped or disabled apart from the 'only'/'except' pragmas.
> Use the 'except' pragma for the job templates to skip jobs which define
> the DISABLE_JOB variable.
What's wrong with using
when: never (or manual to let devs force it from the UI)
'when: never' can only be used in conjunction with the 'rules' keyword
[1],[2]
which in turn is mutually exclusive with 'only/except' [3] which we currently
utilize.
'when: manual' doesn't really feel like it's carrying the meaning
properly.
or
allow_failure: true
I could live with ^this one accompanied by a commentary explaining clearly how
we intend to use it with regular jobs, but still it could cause some confusion
with other jobs where we have perfectly valid use case for using allow_failure
all the time.
With that in mind, I think what I'm proposing is much more verbose in what it's
trying to achieve and in itself it also kind of resembles the try-except
construct (only-except).
[1] https://docs.gitlab.com/ee/ci/yaml/README.html#when
[2] https://gitlab.com/eskultety/libvirt/-/pipelines/240008843
[3] https://docs.gitlab.com/ee/ci/yaml/README.html#rules
Erik
for any jobs we have problem with.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|