Re: [libvirt] [PATCH v4 05/20] backup: Introduce virDomainCheckpointPtr
On 2/9/19 9:48 AM, John Ferlan wrote:
On 2/6/19 2:18 PM, Eric Blake wrote:
> Prepare for introducing a bunch of new public APIs related to
> backup checkpoints by first introducing a new internal type
> and errors associated with that type. Checkpoints are modeled
> heavily after virDomainSnapshotPtr (both represent a point in
> time of the guest), although a snapshot exists with the intent
> of rolling back to that state, while a checkpoint exists to
> make it possible to create an incremental backup at a later
> time.
>
> Signed-off-by: Eric Blake <eblake(a)redhat.com>
>
> @@ -1214,6 +1215,15 @@ const virErrorMsgTuple
virErrorMsgStrings[VIR_ERR_NUMBER_LAST] = {
> [VIR_ERR_NO_NWFILTER_BINDING] = {
> N_("Network filter binding not found"),
> N_("Network filter binding not found: %s") },
> + [VIR_ERR_INVALID_DOMAIN_CHECKPOINT] = {
> + N_("Invalid checkpoint"),
> + N_("Invalid checkpoint: %s") },
Invalid domain checkpoint
Copy and paste from VIR_ERR_INVALID_DOMAIN_SNAPSHOT; will do separate
patch to fix that wording.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org