Re: [libvirt] [PATCH 8/8] qemu: monitor: Separate probing for active block commit
On 08/15/2018 07:52 AM, Peter Krempa wrote:
Extract the code used to probe for the functionality so that it does
not
litter the code used for actual work.
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
src/qemu/qemu_monitor.c | 2 +-
src/qemu/qemu_monitor_json.c | 58 ++++++++++++++++++++++++++------------------
src/qemu/qemu_monitor_json.h | 3 +++
3 files changed, 39 insertions(+), 24 deletions(-)
This one somehow feels related to the other series I reviewed where the
*top was or wasn't present to determine whether capability was there,
but I see that it'd still be useful - just the irony of it all.
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John
diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index 9bc7aa9ed1..a60e78d967 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
NB: My gitk view shows a few lines above here the call to
qemuMonitorJSONBlockCommit has a second row of args that are not aligned
properly... Trivialities.
[...]