Re: [all PATCH] gitlab: add CI job for validating DCO signoff
On Wed, 2020-04-22 at 18:06 +0100, Daniel P. Berrangé wrote:
On Wed, Apr 22, 2020 at 07:01:50PM +0200, Andrea Bolognani wrote:
> I still don't understand why we would want to single out those
> branches and not run the DCO check on them. What harm would it
> cause? It takes around a minute to run it, which is significantly
> less than the other jobs running during the prebuild stage...
The check-dco script doesn't actually work if run against the
main libvirt repo, as it ends up trying to use itself as a
reference and failing to figure out which commits need checking.
Of course that's a bug that's fixable, but in general I think it
is better to not runthe job at all and thus eliminate any risk
of false failures.
It seems to work fine here:
https://gitlab.com/abologna/libvirt/-/jobs/522467078
The corresponding commit is
https://gitlab.com/abologna/libvirt/-/commit/435ef06536f590f4403d0ce59a1b...
where I changed the local require-dco.py script to use the very same
branch I pushed to as the base branch for DCO checking.
I believe you fixed the issue you mention above with
commit 769ff77c9c5afaec97350a4931e5ca123b6af6d2
Author: Daniel P. Berrangé <berrange(a)redhat.com>
Date: Fri Mar 27 14:38:49 2020 +0000
scripts: avoid error in DCO check on empty branches
If the DCO check is run on an empty branch (ie one which has no commits
different from master), it throws an error due to trying to interpret
the empty string as a git commit SHA.
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
v6.1.0-306-g769ff77c9c
So I see no reason not to just run the check on all branches.
If you remove the except: part, and of course the corresponding
comment as well, then
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization