Re: [libvirt] [PATCH v3 11/13] Set cpuCompare handler in drivers
On Thu, Dec 17, 2009 at 12:30:45PM +0100, Jiri Denemark wrote:
...
> > diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c
> > index d6b681c..bede574 100644
> > --- a/src/vbox/vbox_tmpl.c
> > +++ b/src/vbox/vbox_tmpl.c
> > @@ -7049,6 +7049,7 @@ virDriver NAME(Driver) = {
> > vboxIsSecure,
> > vboxDomainIsActive,
> > vboxDomainIsPersistent,
> > + NULL, /* cpuCompare */
> > };
> >
> > virNetworkDriver NAME(NetworkDriver) = {
>
> This one needs to be merged with patch 4, otherwise you can't compile
> the intermediate steps.
OK. I guess api_extension.html needs updating then. It suggests this kind of
patch separation...
Oh, I didn't realize that. Basically the key idea is that you should be
able to compile successfully without warnings, at each step in the pach
series.
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|