Re: [libvirt] [PATCH RFC] storage: perform btrfs clone if possible

On Mon, Nov 24, 2014 at 02:11:47PM +0800, Chen Hanxiao wrote: > We already had nocow flags in virStorageSource. > But when creating RAW file, we don't take advantage > of clone of btrfs. > This file introduce btrfs_clone_file function, > and try to use it when !nocow. > I'm not sure we want to do this, but I have nothing against that either. So I'll just review the code without any other comments.

As I said, I'm not commenting on whether we want this in or not, so for that you should wait for someone's response. I bet there's a (good) reason behind libvirt not using some lvm/zfs/btrfs features, but I am too lazy to search for it since it'd be inaccurate anyway.