On 06/15/2011 10:46 AM, Daniel P. Berrange wrote:
On Wed, Jun 15, 2011 at 10:37:49AM -0600, Eric Blake wrote:
Even though rpc uses 'unsigned int' for the _val parameter that passes the length of item<length>, the public libvirt APIs all use 'int' and filter out lengths < 0, except for virDomainSendKey.
* include/libvirt/libvirt.h.in (virDomainSendKey): All other APIs use int for array length. * src/libvirt.c (virDomainSendKey): Adjust. * src/driver.h (virDrvDomainSendKey): Likewise. * daemon/remote_generator.pl: Likewise. ---
ACK,
If we were starting the API from scratch, I'd say we should have used 'unsigned int' everywhere. Given our existing practice though, we should stick with 'int' everywhere.
Thanks for the review; now pushed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org