On 9/17/20 7:57 PM, Jim Fehlig wrote:
On 9/16/20 3:09 AM, Michal Privoznik wrote:
On 9/10/20 6:18 AM, Marek Marczykowski-Górecki wrote:
b_info->u.hvm.{acpi,apic} are deprecated. But also, on recent libxl version (4.14) the old one seems to be broken. While libxl part should be fixed too, update the usage here and at some point drop support for the old version. b_info->acpi was added in Xen 4.8 b_info->apic was added in Xen 4.10 Xen 4.10 is the oldest version that still has security support (until December 2020).
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com> --- src/libxl/libxl_conf.c | 13 +++++++++++++ tests/libxlxml2domconfigdata/basic-hvm.json | 4 ++-- tests/libxlxml2domconfigdata/cpu-shares-hvm.json | 4 ++-- .../libxlxml2domconfigdata/fullvirt-acpi-slic.json | 4 ++-- .../fullvirt-cpuid-legacy-nest.json | 4 ++-- tests/libxlxml2domconfigdata/fullvirt-cpuid.json | 4 ++-- .../max-eventchannels-hvm.json | 4 ++-- tests/libxlxml2domconfigdata/max-gntframes-hvm.json | 4 ++-- tests/libxlxml2domconfigdata/moredevs-hvm.json | 4 ++-- .../libxlxml2domconfigdata/variable-clock-hvm.json | 4 ++-- .../vnuma-hvm-legacy-nest.json | 4 ++-- tests/libxlxml2domconfigdata/vnuma-hvm.json | 4 ++-- 12 files changed, 35 insertions(+), 22 deletions(-)
This looks good to me.
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
I'll wait a bit with pushing it though in case Jim wants to chime in.
It looks fine to me, so if you want it
Reviewed-by: Jim Fehlig <jfehlig@suse.com>
Thanks, pushed.
On a slightly related note, it would be nice to bump the minimum supported LIBXL_API_VERSION in libvirt. Currently it is set to x040500. I'd like to bump it to 0x040800 (or perhaps higher). In fact, I have a downstream patch to do just that
https://build.opensuse.org/package/view_file/Virtualization/libvirt/suse-bum...
The problem is this API version was never advertised by libxl until Xen 4.13 with commit c3999835df
http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=c3999835df2d9917cf4b50be...
We would need that commit backported to all downstream Xen packages that libvirt is expected to build against, which we've done at SUSE. But I can't expect that from all the other distros wired up to the CI. Suggestions welcome :-).
Yeah, that's very unfortunate. I don't think I have a good answer, probably we have to wait until we can bump to 4.13 :-( Michal