Re: [libvirt] [PATCH v3 09/17] qemu: Implement @access for <memory/> banks
On 03/09/2017 11:06 AM, Michal Privoznik wrote:
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/qemu/qemu_command.c | 5 +++--
.../qemuxml2argv-memory-hotplug-nvdimm-access.args | 26 ++++++++++++++++++++++
tests/qemuxml2argvtest.c | 2 ++
3 files changed, 31 insertions(+), 2 deletions(-)
create mode 100644
tests/qemuxml2argvdata/qemuxml2argv-memory-hotplug-nvdimm-access.args
Hmm ... I guess the note I made in previous review would need the
amendment regarding whether or not the specific dimm defined an access
mode. If it didn't, but was using a numa node, then it would take on the
numa node's access; otherwise, if an access is defined, then regardless
of what's set for memoryBacking - the access for the nvdimm would be used.
ACK for what's here though... I'm just glad I don't have to configure
these - it's such a tangled web
John