Re: [libvirt] [PATCH] xenconfig: Remove references to my name and email

On 05/08/2018 03:22 AM, David Kiarie wrote: > > > On Tue, May 8, 2018 at 2:11 AM, Jim Fehlig <jfehlig(a)suse.com <mailto: > jfehlig(a)suse.com&gt;&gt; wrote: > > On 05/07/2018 08:57 AM, David Kiarie wrote: > > > > On Mon, May 7, 2018 at 5:55 PM, David Kiarie < > davidkiarie4(a)gmail.com > <mailto:davidkiarie4@gmail.com> <mailto:davidkiarie4@gmail.com > <mailto:davidkiarie4@gmail.com>>> wrote: > > > > On Mon, May 7, 2018 at 10:29 AM, Peter Krempa < > pkrempa(a)redhat.com > <mailto:pkrempa@redhat.com> > <mailto:pkrempa@redhat.com <mailto:pkrempa@redhat.com>>> > wrote: > > On Sat, May 05, 2018 at 12:17:05 +0300, David Kiarie > wrote: > > On Sat, May 5, 2018 at 12:15 PM, David Kiarie > <davidkiarie4(a)gmail.com <mailto:davidkiarie4@gmail.com> > <mailto:davidkiarie4@gmail.com <mailto:davidkiarie4@gmail.com>>> > > wrote: > > > > Replace references to my name and email > with a > pseudonym > > > > > > Sorry, I just want my real name and email > off these > files and I keep making > > silly mistakes. > > How about just deleting them? We don't really support > using > pseudonyms. > > > Why is that ? With a person reason I don't want my name of > these > files. I > wrote the files and it took me a lot of work. > > I can still prove I wrote this code with the above email if > anyone > wants me > to as I still work as a developer. > > > I initally requested to have my name removed from the files but > apparently I hadn't signed off the patch so it was rejected. > > > You could have simply replied to the mail requesting a SOB and one of > us > would have added it your patch and pushed it. > > One month later, I figured it might be a bad idea to just give up > all > the work I had done and opted to keep track of it. > > > I think that is a wise choice, in which case you should leave the > authorship > as is :-). > > > I do have a good reason as to why I would like to remove my name from > these files which I will not bother explaining. And I actually do want my > name removed from these files. > Understood. We could have pushed the first version of your patch if it had a SOB. Presence of a SOB is enforced by a commit hook, so the patch couldn't be pushed without it. That wasn't enforced when you were working on the project. Apologies for not making that clearer at the beginning of this thread, saving everyone some time. Removing my name on the other hand means I give up on something which I > painstakingly worked on for almost one year. > As Daniel already mentioned, git contains a better history of your contributions. Interaction with the project is also recorded in the mail list archives.

Regards, Jim