Re: [PATCH 8/8] tools: virsh: Reset error when keepalive registration fails
On Thu, Nov 12, 2020 at 16:17:22 +0100, Ján Tomko wrote:
On a Thursday in 2020, Peter Krempa wrote:
> We try to enable keepalive oportunistically. If it's not supported by
*opportunistically
> the connection driver and it was not explicitly requested we keep the
> error object set and can report it in some cases accidentally:
I was going to complain about the trailing ':' when I realized 'git am'
dropped everything below. Consider indenting it or using a different
separator.
oops, I've copypasted from test output and it didn't occur to me.
Jano
>
> --- stdout ---
> TEST: /home/pipo/libvirt/tests/virsh-self-test
> ! 1 FAILED
> --- stderr ---
> error: parameter 'target' of command 'attach-disk' must be listed
before optional parameters
> error: this function is not supported by the connection driver:
virConnectSetKeepAlive
> -------
>
> Clear the stored libvirt error.
>
> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
> ---
> tools/virsh.c | 1 +
> 1 file changed, 1 insertion(+)