Re: [libvirt-ci PATCH 07/12] lcitool: Update the config values with internal playbook settings
On Wed, 2020-05-06 at 14:05 +0200, Erik Skultety wrote:
- extra_vars = {
+ self._config.values.update({
"base": base,
"playbook_base": playbook_base,
- "root_password_file": root_pass_file,
- "flavor": flavor,
"selected_projects": selected_projects,
"git_remote": git_remote,
"git_branch": git_branch,
- "gitlab_url_file": gitlab_url_file,
- "gitlab_runner_token_file": gitlab_runner_token_file,
- }
+ })
I think this would be nicer as
extra_vars = self._config.values
extra_vars.update({
...
})
but, either with your version or mine, the patch is still
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
--
Andrea Bolognani / Red Hat / Virtualization