Re: [libvirt] [PATCH v10] support offline migration

On Thu, Oct 11, 2012 at 12:17:56PM +0800, liguang wrote: > original migration did not aware of offline case, > so, try to support offline migration quietly > (did not disturb original migration) by pass > VIR_MIGRATE_OFFLINE flag to migration APIs if only > the domain is really inactive, and > migration process will not puzzled by domain > offline and exit unexpectedly. > these changes did not take care of disk images the > domain required, for them could be transferred by > other APIs as suggested, then VIR_MIGRATE_OFFLINE > should not combined with VIR_MIGRATE_NON_SHARED_*. > if you want a persistent migration, > you should do "virsh migrate --persistent" youself. > > Signed-off-by: liguang <lig.fnst(a)cn.fujitsu.com&gt; This is still not quite working correctly. The following command must *not* run # virsh -c qemu+ssh://root@avocado/system migrate vm1 --offline qemu+ssh://root@mustard/system because it does not include the '--persistent' flag. If I do set the --persistent flag though, that is now correctly operating. Likewise --undefinesource is working now. The other bug remaining is that you are still creating an XML file /var/run/libvirt/qemu/$GUESTNAME.xml for the inactive guest. This is bogus, because that file should only exist if the guest is running. Daniel