Re: [libvirt] [PATCH] uml: sanity check external data before using it

3 Mar 2010


      According to Jim Meyering on 3/3/2010 9:41 AM:
...
Eric Blake wrote:
...
if (nbytes < sizeof res) {
-            virReportSystemError(errno,
+            virReportSystemError(0,
                                  _("incomplete reply %s"),
                                  cmd);
             goto error;
         }
+        if (sizeof res < res.length) {
+            virReportSystemError(0,
+                                 _("invalid length in reply %s"),
Hmm... while you're there, you might want to save 4 lines by joining
those unnecessarily-continued ones:
virReportSystemError(0, _("invalid length in reply %s"), cmd);
Sure.  Respin coming up (this time, in a new thread, to make it easier to
spot).

-- 
Eric Blake   eblake@redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org