Re: [libvirt] [PATCH 0/6 v3] Add blkio cgroup support

Hi not that I tested this patch or the patch that followed (adding blkiotune command) ... but the way I understand, the cgroup blkio controller does only work for sync'd IO/queues. quote blkio-controller.txt from 2.6.37: Currently only sync IO queues are support. All the buffered writes are still system wide and not per group. When I last tested this (using manual cgroups commands), this seemed true. So may I ask how you use this and how this helps in which setup?

Regards Dominik On 02/08/2011 07:38 AM, Gui Jianfeng wrote: > Hi > > This patchset adds blkio cgroup support for qemu and lxc. > > [PATCH 1/6] cgroup: Enable cgroup hierarchy for blkio cgroup > [PATCH 2/6 v3] cgroup: Implement blkio.weight tuning API. > [PATCH 3/6] Update XML Schema for new entries. > [PATCH 4/6 v3] qemu: Implement blkio tunable XML configuration and parsing. > [PATCH 5/6 v3] LXC: LXC Blkio weight configuration support. > [PATCH 6/6] Add documentation for blkiotune elements. > > Will post a patchset to implement virsh command "blkiotune" to tune blkio > cgroup parameter later on. > > v2 -> v3 Changes: > o Remove an unused local variable > o Rename virCgroup(Set/Get)Weight to virCgroup(Set/Get)BlkioWeight > o Add documentation in docs/formatdomain.html.in > o Update XML Schema for new entries. > > docs/formatdomain.html.in | 10 ++++++++++ > docs/schemas/domain.rng | 20 ++++++++++++++++++++ > src/conf/domain_conf.c | 13 +++++++++++++ > src/conf/domain_conf.h | 4 ++++ > src/libvirt_private.syms | 2 ++ > src/lxc/lxc_controller.c | 10 ++++++++++ > src/qemu/qemu_cgroup.c | 16 +++++++++++++++- > src/qemu/qemu_conf.c | 3 ++- > src/util/cgroup.c | 41 ++++++++++++++++++++++++++++++++++++++++- > src/util/cgroup.h | 4 ++++ > 10 files changed, 120 insertions(+), 3 deletions(-) > > > Thanks > Gui > > -- > libvir-list mailing list > libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list >