Re: [libvirt] [PATCH 1/13] Adding recursive locks

> void virMutexDestroy(virMutexPtr m) > { > pthread_mutex_destroy(&m->lock); Minor point, I think it would be better to call it

so we keep the standard virMutex prefix for naming convention

> Index: libvirt-acl/src/util/threads-pthread.h > =================================================================== > --- libvirt-acl.orig/src/util/threads-pthread.h > +++ libvirt-acl/src/util/threads-pthread.h > @@ -24,6 +24,7 @@ > #include <pthread.h> > > struct virMutex { > + pthread_mutexattr_t attr; > pthread_mutex_t lock; > }; I don't think this is neccessary - the attributes are only used at time of pthread_mutex_init() call, so don't need to be kept around after that. Thus the 'pthread_mutexattr_t attr' could just be a local variable in virRecursiveMutexInit().